[main] Update dependencies from dotnet/roslyn #98559

dotnet-maestro · 2024-02-16T13:36:41Z

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: 037eb78c-9902-4cb9-856d-08db8ed7cafd
Build: 20240311.10
Date Produced: March 12, 2024 3:46:39 AM UTC
Commit: c3565da812d99adf841cb96a764a27d8a93e22ef
Branch: refs/heads/main

Updates:
- Microsoft.SourceBuild.Intermediate.roslyn: from 4.10.0-2.24114.13 to 4.10.0-3.24161.10
- Microsoft.CodeAnalysis: from 4.10.0-2.24114.13 to 4.10.0-3.24161.10
- Microsoft.CodeAnalysis.CSharp: from 4.10.0-2.24114.13 to 4.10.0-3.24161.10
- Microsoft.Net.Compilers.Toolset: from 4.10.0-2.24114.13 to 4.10.0-3.24161.10

…215.8 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24115.8

…216.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24116.4

…220.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24120.1

lewing · 2024-02-21T01:27:15Z

@BrzVlad 'MONO interpreter: NIY encountered in method (wrapper dynamic-method) object:lambda_method12 (System.Runtime.CompilerServices.Closure)'

ghost · 2024-02-21T01:27:43Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: 037eb78c-9902-4cb9-856d-08db8ed7cafd
Build: 20240220.1
Date Produced: February 20, 2024 12:10:58 PM UTC
Commit: 25aa74d725e801b8232dbb3e5abcda0fa72da8c5
Branch: refs/heads/main

Updates:
- Microsoft.SourceBuild.Intermediate.roslyn: from 4.10.0-2.24114.13 to 4.10.0-2.24120.1
- Microsoft.CodeAnalysis: from 4.10.0-2.24114.13 to 4.10.0-2.24120.1
- Microsoft.CodeAnalysis.CSharp: from 4.10.0-2.24114.13 to 4.10.0-2.24120.1
- Microsoft.Net.Compilers.Toolset: from 4.10.0-2.24114.13 to 4.10.0-2.24120.1

Author:	dotnet-maestro[bot]
Assignees:	-
Labels:	`area-Codegen-Interpreter-mono`, `area-codeflow`
Milestone:	-

lewing · 2024-02-21T02:28:47Z

this hit #98730

…221.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24121.2

…221.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24121.4

…222.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24122.5

lewing · 2024-02-23T16:25:58Z

A value of type 'System.Threading.Lock' converted to a different type will use likely unintended monitor-based locking in 'lock' statement.

…223.6 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24123.6

…224.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24124.2

…222.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24122.4

mangod9 · 2024-02-26T21:38:43Z

@jaredpar @kouvel the new Lock related Roslyn changes are causing a build break in Lock.cs:


 @azure-pipelines azure-pipelines
/ runtime (Build Libraries Build linux arm64 Debug)

src/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs#L123
src/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs(123,21): error CS9216: (NETCORE_ENGINEERING_TELEMETRY=Build) A value of type 'System.Threading.Lock' converted to a different type will use likely unintended monitor-based locking in 'lock' statement.

Perhaps the static analyzer needs a special case here?

AaronRobinsonMSFT · 2024-04-01T18:26:53Z

I'm able to reproduce this locally. I have a DMP. There is a lot going on here. Still looking into the core issue. My repro is a Checked runtime, Debug Libraries on x86 Windows.

AaronRobinsonMSFT · 2024-04-01T21:20:34Z

Quick update. Running on main, the dotnet.exe process peaks at 300 MB and then settles between 110 MB and 140 MB for the rest of the tests. When running with from this branch, the dotnet.exe process peaks at 1.7 GB and crashes. I'm doing a bisect now to try and determine where this was introduced, but from what I've seen this is starting to look like something introduced by the new Roslyn API.

The ParallelTheory creates an environment that overwhelms the GC and Finalizer thread on x86. The result is OOMs in the 32-bit memory address space.

AaronRobinsonMSFT · 2024-04-04T00:55:30Z

The current working theory for the OOM issue is a confluence of two changes.

Converted the interop tests to use ParallelTheory.
Improvments in the Workspace layer in the Roslyn SDK.

The result is that ParallelTheory permits most/all tests to run concurrently. Improvements in the Roslyn SDK have been to reduce the inherent limits on concurrent Compilation. The result is the Roslyn SDK has been streamlined and the GC and Finalizer thread can't keep up with the increased garbage produced by the Compilations.

The potential OOM was simply hidden because we are genuinly generating too much garbage and this was fine until Roslyn made performance improvements and let us hurt ourselves.

…402.15 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24202.15

AaronRobinsonMSFT · 2024-04-04T03:47:32Z

@stephentoub Looks like the WASM runtime doesn't support something.

[03:20:40] info: [FAIL] System.Text.RegularExpressions.Tests.RegexRustTests.MatchStartAndEndPositions
[03:20:40] info: System.PlatformNotSupportedException : Cannot wait on monitors on this runtime.
[03:20:40] info:    at System.Threading.Monitor.ObjWait(Int32 millisecondsTimeout, Object obj)
[03:20:40] info:    at System.Threading.Monitor.Wait(Object obj, Int32 millisecondsTimeout)
[03:20:40] info:    at System.Threading.ManualResetEventSlim.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
[03:20:40] info:    at System.Threading.Tasks.Task.SpinThenBlockingWait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
[03:20:40] info:    at System.Threading.Tasks.Task.InternalWaitCore(Int32 millisecondsTimeout, CancellationToken cancellationToken)
[03:20:40] info:    at System.Threading.Tasks.Task.InternalWait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
[03:20:40] info:    at System.Threading.Tasks.Task`1[[System.Text.RegularExpressions.Regex[], System.Text.RegularExpressions, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].GetResultCore(Boolean waitCompletionNotification)
[03:20:40] info:    at System.Threading.Tasks.Task`1[[System.Text.RegularExpressions.Regex[], System.Text.RegularExpressions, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].get_Result()
[03:20:40] info:    at System.Text.RegularExpressions.Tests.RegexHelpers.GetRegexes(RegexEngine engine, ValueTuple`4[] regexes)
[03:20:40] info:    at System.Text.RegularExpressions.Tests.RegexRustTests.MatchStartAndEndPositions_MemberData()+MoveNext()
[03:20:40] info:    at System.Linq.Enumerable.IEnumerableSelectIterator`2[[System.Object, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Object[], System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()

stephentoub · 2024-04-04T13:24:51Z

@sbomer, @agocke, all failures are known except for this one:

❌ Mono.Linker.Tests.TestCases.All.DataFlow(t: \"DynamicObjects\")
Exception Message
Expected to find warning: warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.InvocationOnDynamicType.ObjectCreationDynamicArgument(): and message containing 'Microsoft.CSharp.RuntimeBinder.Binder.InvokeConstructor', but no such message was found.\nLogged messages:\nILC: Trim analysis warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicInRequiresUnreferencedCodeClass.Test(): Using member 'Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicInRequiresUnreferencedCodeClass.ClassWithRequires.MethodWithDynamicArg(Object)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. message.\nILC: Trim analysis warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.InvocationOnDynamicTypeInMethodWithRUCDoesNotWarnTwoTimes.Test(): Using member 'Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.InvocationOnDynamicTypeInMethodWithRUCDoesNotWarnTwoTimes.MethodWithRequires()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. We should only see the warning related to this annotation, and none about the dynamic type.\nILC: AOT analysis warning IL3050: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.InvocationOnDynamicTypeInMethodWithRUCDoesNotWarnTwoTimes.Test(): Using member 'Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.InvocationOnDynamicTypeInMethodWithRUCDoesNotWarnTwoTimes.MethodWithRequires()' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. We should only see the warning related to this annotation, and none about the dynamic type.\nILC: AOT analysis warning IL3050: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicInRequiresUnreferencedCodeClass.ClassWithRequires.MethodWithDynamicArg(Object): Using member 'System.Runtime.CompilerServices.CallSite`1<Action`2<CallSite,Object>>.Create(CallSiteBinder)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Creating arrays at runtime requires dynamic code generation.\nILC: Trim analysis warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicIndexerAccess.Read(Object): Using member 'Microsoft.CSharp.RuntimeBinder.Binder.GetIndex(CSharpBinderFlags,Type,IEnumerable`1<CSharpArgumentInfo>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Using dynamic types might cause types or members to be removed by trimmer.\nILC: AOT analysis warning IL3050: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicIndexerAccess.Read(Object): Using member 'System.Runtime.CompilerServices.CallSite`1<Func`4<CallSite,Object,Int32,Object>>.Create(CallSiteBinder)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Creating arrays at runtime requires dynamic code generation.\nILC: Trim analysis warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicIndexerAccess.Write(Object): Using member 'Microsoft.CSharp.RuntimeBinder.Binder.SetIndex(CSharpBinderFlags,Type,IEnumerable`1<CSharpArgumentInfo>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Using dynamic types might cause types or members to be removed by trimmer.\nILC: AOT analysis warning IL3050: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicIndexerAccess.Write(Object): Using member 'System.Runtime.CompilerServices.CallSite`1<Func`5<CallSite,Object,Int32,Int32,Object>>.Create(CallSiteBinder)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Creating arrays at runtime requires dynamic code generation.\nILC: Trim analysis warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicMemberReference.Read(Object): Using member 'Microsoft.CSharp.RuntimeBinder.Binder.GetMember(CSharpBinderFlags,String,Type,IEnumerable`1<CSharpArgumentInfo>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Using dynamic types might cause types or members to be removed by trimmer.\nILC: AOT analysis warning IL3050: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicMemberReference.Read(Object): Using member 'System.Runtime.CompilerServices.CallSite`1<Func`3<CallSite,Object,Object>>.Create(CallSiteBinder)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Creating arrays at runtime requires dynamic code generation.\nILC: Trim analysis warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicMemberReference.Write(Object): Using member 'Microsoft.CSharp.RuntimeBinder.Binder.SetMember(CSharpBinderFlags,String,Type,IEnumerable`1<CSharpArgumentInfo>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Using dynamic types might cause types or members to be removed by trimmer.\nILC: AOT analysis warning IL3050: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicMemberReference.Write(Object): Using member 'System.Runtime.CompilerServices.CallSite`1<Func`4<CallSite,Object,Int32,Object>>.Create(CallSiteBinder)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Creating arrays at runtime requires dynamic code generation.\n/_/src/libraries/System.Linq.Expressions/src/System/Runtime/CompilerServices/CallSiteOpsReflectionCache.cs(36): AOT analysis warning IL3050: System.Runtime.CompilerServices.CallSiteOpsReflectionCache`1..cctor(): Using member 'System.Runtime.CompilerServices.CallSiteOps.Bind<T>(CallSiteBinder,CallSite`1<T>,Object[])' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Creating arrays at runtime requires dynamic code generation.
Stack Trace
   at Mono.Linker.Tests.TestCasesRunner.ResultChecker.VerifyLoggedMessages(AssemblyDefinition original, TrimmingTestLogger logger, Boolean checkRemainingErrors) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ResultChecker.cs:line 345
   at Mono.Linker.Tests.TestCasesRunner.ResultChecker.AdditionalChecking(TrimmedTestCaseResult linkResult, AssemblyDefinition original) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ResultChecker.cs:line 157
   at Mono.Linker.Tests.TestCasesRunner.ResultChecker.Check(TrimmedTestCaseResult testResult) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ResultChecker.cs:line 70
   at Mono.Linker.Tests.TestCases.All.Run(String testName) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCases/TestSuites.cs:line 155
   at Mono.Linker.Tests.TestCases.All.DataFlow(String t) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCases/TestSuites.cs:line 16
   at InvokeStub_All.DataFlow(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Is this new?

sbomer · 2024-04-04T17:10:56Z

Working on a fix. The test in question is sensitive to Roslyn codegen for dynamic that changed.

Roslyn no longer generates a call to InvokeConstructor.

sbomer · 2024-04-04T17:24:26Z

I'm just commenting out this test to unblock dependency flow. I couldn't find a way to make Roslyn generate a call to Binder.InvokeConstructor, so disabling the test for now.

stephentoub · 2024-04-05T00:43:11Z

Remaining failure is known. Thanks, all.

* Update dependencies from https://github.com/dotnet/roslyn build 20240215.8 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24115.8 * Update dependencies from https://github.com/dotnet/roslyn build 20240216.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24116.4 * Update dependencies from https://github.com/dotnet/roslyn build 20240216.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24116.4 * Update dependencies from https://github.com/dotnet/roslyn build 20240216.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24116.4 * Update dependencies from https://github.com/dotnet/roslyn build 20240220.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24120.1 * Update dependencies from https://github.com/dotnet/roslyn build 20240221.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24121.2 * Update dependencies from https://github.com/dotnet/roslyn build 20240221.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24121.4 * Update dependencies from https://github.com/dotnet/roslyn build 20240222.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24122.5 * Update dependencies from https://github.com/dotnet/roslyn build 20240223.6 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24123.6 * Update dependencies from https://github.com/dotnet/roslyn build 20240224.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24124.2 * Update dependencies from https://github.com/dotnet/roslyn build 20240222.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24122.4 * Avoid/suppress Lock-to-object conversion warnings * Update dependencies from https://github.com/dotnet/roslyn build 20240227.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24127.1 * Update dependencies from https://github.com/dotnet/roslyn build 20240227.10 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24127.10 * Update dependencies from https://github.com/dotnet/roslyn build 20240228.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24128.4 * Update dependencies from https://github.com/dotnet/roslyn build 20240301.3 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24151.3 * Update dependencies from https://github.com/dotnet/roslyn build 20240301.8 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24151.8 * Update dependencies from https://github.com/dotnet/roslyn build 20240301.8 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24151.8 * Update dependencies from https://github.com/dotnet/roslyn build 20240301.8 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24151.8 * Update dependencies from https://github.com/dotnet/roslyn build 20240305.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24155.1 * Update dependencies from https://github.com/dotnet/roslyn build 20240305.13 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24155.13 * Suppress more Lock-to-object warnings * Remove invalid source build element * Update dependencies from https://github.com/dotnet/roslyn build 20240306.11 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24156.11 * Update dependencies from https://github.com/dotnet/roslyn build 20240307.14 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24157.14 * Update dependencies from https://github.com/dotnet/roslyn build 20240308.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24158.5 * Update dependencies from https://github.com/dotnet/roslyn build 20240308.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24158.5 * Update dependencies from https://github.com/dotnet/roslyn build 20240311.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24161.2 * Update dependencies from https://github.com/dotnet/roslyn build 20240311.10 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24161.10 * Update dependencies from https://github.com/dotnet/roslyn build Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24172.1 * Update dependencies from https://github.com/dotnet/roslyn build Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24175.2 * Workaround compiler changes related to dynamic * Work around Microsoft.CSharp test failure due to dynamic changes * Update dependencies from https://github.com/dotnet/roslyn build Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.11.0-1.24176.2 * Update dependencies from https://github.com/dotnet/roslyn build 20240330.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.11.0-1.24180.2 * Convert ParallelTheory to Theory in InteropService test suites. The ParallelTheory creates an environment that overwhelms the GC and Finalizer thread on x86. The result is OOMs in the 32-bit memory address space. * Fix deadlocking in regex tests * Update dependencies from https://github.com/dotnet/roslyn build 20240402.15 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24202.15 * Fix wasm * Comment out test for InvokeConstructor Roslyn no longer generates a call to InvokeConstructor. --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Jan Jones <janjones@microsoft.com> Co-authored-by: Pavel Savara <pavel.savara@gmail.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Aaron R Robinson <arobins@microsoft.com> Co-authored-by: Sven Boemer <sbomer@gmail.com>

Update dependencies from https://github.com/dotnet/roslyn build 20240…

10431ef

…215.8 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24115.8

dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Feb 16, 2024

This was referenced Feb 16, 2024

Tracking issue for CI build timeouts #76454

Closed

[browser] RuntimeError: memory access out of bounds #96546

Closed

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

dotnet-maestro bot added 3 commits February 17, 2024 13:24

Update dependencies from https://github.com/dotnet/roslyn build 20240…

4b10d01

…216.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24116.4

Update dependencies from https://github.com/dotnet/roslyn build 20240…

4aee333

…216.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24116.4

Update dependencies from https://github.com/dotnet/roslyn build 20240…

7467db2

…216.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24116.4

build-analysis bot mentioned this pull request Feb 19, 2024

Segmentation fault in System.Text.RegularExpressions.Tests #93206

Closed

Update dependencies from https://github.com/dotnet/roslyn build 20240…

7c512e7

…220.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24120.1

build-analysis bot mentioned this pull request Feb 20, 2024

[mono][tvos] OOM in System.IO.Tests.MemoryStreamTests #92467

Closed

lewing added the area-Codegen-Interpreter-mono label Feb 21, 2024

lewing added this to the 9.0.0 milestone Feb 21, 2024

Merge branch 'main' into darc-main-bed17ca1-ec05-4967-aa6f-c01d1f555d23

916cb11

lewing previously approved these changes Feb 21, 2024

View reviewed changes

This was referenced Feb 21, 2024

MONO interpreter: NIY encountered in method #98730

Closed

Workloads-NoWebcil-Wasm.Build.Tests.TestAppScenarios.DebugLevelTests timeout #98734

Closed

dotnet-maestro bot added 3 commits February 21, 2024 13:19

Update dependencies from https://github.com/dotnet/roslyn build 20240…

d04e132

…221.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24121.2

Update dependencies from https://github.com/dotnet/roslyn build 20240…

e60c680

…221.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24121.4

Update dependencies from https://github.com/dotnet/roslyn build 20240…

442ab6e

…222.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24122.5

dotnet-maestro bot added 3 commits February 24, 2024 13:21

Update dependencies from https://github.com/dotnet/roslyn build 20240…

4343278

…223.6 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24123.6

Update dependencies from https://github.com/dotnet/roslyn build 20240…

109b7d3

…224.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24124.2

Update dependencies from https://github.com/dotnet/roslyn build 20240…

0a02161

…222.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24122.4

lewing removed the area-Codegen-Interpreter-mono label Feb 26, 2024

Merge branch 'main' into darc-main-bed17ca1-ec05-4967-aa6f-c01d1f555d23

b63ab63

lewing mentioned this pull request Apr 1, 2024

[main] Update dependencies from dotnet/roslyn #100483

Closed

Convert ParallelTheory to Theory in InteropService test suites.

341e2fb

The ParallelTheory creates an environment that overwhelms the GC and Finalizer thread on x86. The result is OOMs in the 32-bit memory address space.

stephentoub and others added 3 commits April 3, 2024 21:55

Merge branch 'main' into darc-main-bed17ca1-ec05-4967-aa6f-c01d1f555d23

a194247

Fix deadlocking in regex tests

87103f2

Update dependencies from https://github.com/dotnet/roslyn build 20240…

754cf1a

…402.15 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24202.15

stephentoub approved these changes Apr 4, 2024

View reviewed changes

AaronRobinsonMSFT approved these changes Apr 4, 2024

View reviewed changes

This was referenced Apr 4, 2024

[MT][browser] MutexTests.AbandonExisting #98830

Closed

System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558

Open

Fix wasm

65e0cef

build-analysis bot mentioned this pull request Apr 4, 2024

System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783

Open

sbomer mentioned this pull request Apr 4, 2024

[ILLink analyzer] Analyzer doesn't produce RequiresDynamicCode warnings for dynamic objects #94427

Open

Comment out test for InvokeConstructor

1104cea

Roslyn no longer generates a call to InvokeConstructor.

dotnet-maestro bot requested a review from marek-safar as a code owner April 4, 2024 17:23

This was referenced Apr 4, 2024

[wasm] Assertion: should not be reached at D:/a/_work/1/s/src/mono/mono/sgen/sgen-scan-object.h:93 in System.Reflection.Tests #95805

Closed

[browser][MT] GC deadlock #96190

Closed

[browser] Process terminated assert handling at icall.c:6162 #100249

Closed

stephentoub merged commit d86b84f into main Apr 5, 2024
164 of 166 checks passed

stephentoub deleted the darc-main-bed17ca1-ec05-4967-aa6f-c01d1f555d23 branch April 5, 2024 00:43

build-analysis bot mentioned this pull request May 2, 2024

[wasm][AOT] emcc : error - received SIGKILL (-9) #89402

Open

github-actions bot locked and limited conversation to collaborators May 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/roslyn #98559

[main] Update dependencies from dotnet/roslyn #98559

dotnet-maestro bot commented Feb 16, 2024 •

edited

Loading

lewing commented Feb 21, 2024

ghost commented Feb 21, 2024

From https://github.com/dotnet/roslyn

lewing commented Feb 21, 2024

lewing commented Feb 23, 2024

mangod9 commented Feb 26, 2024 •

edited

Loading

AaronRobinsonMSFT commented Apr 1, 2024

AaronRobinsonMSFT commented Apr 1, 2024

AaronRobinsonMSFT commented Apr 4, 2024

AaronRobinsonMSFT commented Apr 4, 2024

stephentoub commented Apr 4, 2024

sbomer commented Apr 4, 2024

sbomer commented Apr 4, 2024

stephentoub commented Apr 5, 2024

[main] Update dependencies from dotnet/roslyn #98559

[main] Update dependencies from dotnet/roslyn #98559

Conversation

dotnet-maestro bot commented Feb 16, 2024 • edited Loading

From https://github.com/dotnet/roslyn

lewing commented Feb 21, 2024

ghost commented Feb 21, 2024

From https://github.com/dotnet/roslyn

lewing commented Feb 21, 2024

lewing commented Feb 23, 2024

mangod9 commented Feb 26, 2024 • edited Loading

AaronRobinsonMSFT commented Apr 1, 2024

AaronRobinsonMSFT commented Apr 1, 2024

AaronRobinsonMSFT commented Apr 4, 2024

AaronRobinsonMSFT commented Apr 4, 2024

stephentoub commented Apr 4, 2024

sbomer commented Apr 4, 2024

sbomer commented Apr 4, 2024

stephentoub commented Apr 5, 2024

dotnet-maestro bot commented Feb 16, 2024 •

edited

Loading

mangod9 commented Feb 26, 2024 •

edited

Loading